[Infra UI] Fix process charts after refactoring #168159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
mykolaharmash
approved these changes
Oct 6, 2023
jennypavlova
deleted the
168156-infra-ui-process-list-charts-are-not-loading
branch
jennypavlova
restored the
168156-infra-ui-process-list-charts-are-not-loading
branch
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2023
Closes elastic#168156 ## Summary This PR fixes process charts error:  I assume that after the merge of the refactoring PR, those files were recreated by another PR or most likely when `main` was merged to [the refactoring PR](elastic#166965) with them as resolved conflicts. Deleting the files again fixed the issue. ## Testing I found the issue on serverless but it probably can be reproduced on on-prem as well On Serverless: - Start a local es instance: `yarn es serverless --kill --clean --license trial --ssl` - Enable infra in the `serverless.oblt.dev.yml` file: - `xpack.infra.enabled: true` - Start a local kibana instance: `yarn serverless-oblt --ssl` and see if the side nav contains the Infrastructure item - Navigate to https://0.0.0.0:5601/ftw/app/hosts and open Asset details flyout or page - Click on the process tab and expand one of the processes - The charts (CPU and Memory) should be visible (cherry picked from commit 000b70c)
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2023
…8210) # Backport This will backport the following commits from `main` to `8.11`: - [[Infra UI] Fix process charts after refactoring (#168159)](#168159) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-06T12:01:19Z","message":"[Infra UI] Fix process charts after refactoring (#168159)\n\nCloses #168156 \r\n## Summary\r\n\r\nThis PR fixes process charts error: \r\n\r\n\r\n\r\nI assume that after the merge of the refactoring PR, those files were\r\nrecreated by another PR or most likely when `main` was merged to [the\r\nrefactoring PR](#166965) with them\r\nas resolved conflicts. Deleting the files again fixed the issue.\r\n\r\n## Testing\r\nI found the issue on serverless but it probably can be reproduced on\r\non-prem as well\r\nOn Serverless: \r\n- Start a local es instance: `yarn es serverless --kill --clean\r\n--license trial --ssl`\r\n- Enable infra in the `serverless.oblt.dev.yml` file:\r\n - `xpack.infra.enabled: true`\r\n- Start a local kibana instance: `yarn serverless-oblt --ssl` and see if\r\nthe side nav contains the Infrastructure item\r\n- Navigate to https://0.0.0.0:5601/ftw/app/hosts and open Asset details\r\nflyout or page\r\n- Click on the process tab and expand one of the processes\r\n- The charts (CPU and Memory) should be visible","sha":"000b70c000ec1c8ce9d2ccda6faf60247116a263","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.12.0"],"number":168159,"url":"https://github.com/elastic/kibana/pull/168159","mergeCommit":{"message":"[Infra UI] Fix process charts after refactoring (#168159)\n\nCloses #168156 \r\n## Summary\r\n\r\nThis PR fixes process charts error: \r\n\r\n\r\n\r\nI assume that after the merge of the refactoring PR, those files were\r\nrecreated by another PR or most likely when `main` was merged to [the\r\nrefactoring PR](#166965) with them\r\nas resolved conflicts. Deleting the files again fixed the issue.\r\n\r\n## Testing\r\nI found the issue on serverless but it probably can be reproduced on\r\non-prem as well\r\nOn Serverless: \r\n- Start a local es instance: `yarn es serverless --kill --clean\r\n--license trial --ssl`\r\n- Enable infra in the `serverless.oblt.dev.yml` file:\r\n - `xpack.infra.enabled: true`\r\n- Start a local kibana instance: `yarn serverless-oblt --ssl` and see if\r\nthe side nav contains the Infrastructure item\r\n- Navigate to https://0.0.0.0:5601/ftw/app/hosts and open Asset details\r\nflyout or page\r\n- Click on the process tab and expand one of the processes\r\n- The charts (CPU and Memory) should be visible","sha":"000b70c000ec1c8ce9d2ccda6faf60247116a263"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168159","number":168159,"mergeCommit":{"message":"[Infra UI] Fix process charts after refactoring (#168159)\n\nCloses #168156 \r\n## Summary\r\n\r\nThis PR fixes process charts error: \r\n\r\n\r\n\r\nI assume that after the merge of the refactoring PR, those files were\r\nrecreated by another PR or most likely when `main` was merged to [the\r\nrefactoring PR](#166965) with them\r\nas resolved conflicts. Deleting the files again fixed the issue.\r\n\r\n## Testing\r\nI found the issue on serverless but it probably can be reproduced on\r\non-prem as well\r\nOn Serverless: \r\n- Start a local es instance: `yarn es serverless --kill --clean\r\n--license trial --ssl`\r\n- Enable infra in the `serverless.oblt.dev.yml` file:\r\n - `xpack.infra.enabled: true`\r\n- Start a local kibana instance: `yarn serverless-oblt --ssl` and see if\r\nthe side nav contains the Infrastructure item\r\n- Navigate to https://0.0.0.0:5601/ftw/app/hosts and open Asset details\r\nflyout or page\r\n- Click on the process tab and expand one of the processes\r\n- The charts (CPU and Memory) should be visible","sha":"000b70c000ec1c8ce9d2ccda6faf60247116a263"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Closes elastic#168156 ## Summary This PR fixes process charts error:  I assume that after the merge of the refactoring PR, those files were recreated by another PR or most likely when `main` was merged to [the refactoring PR](elastic#166965) with them as resolved conflicts. Deleting the files again fixed the issue. ## Testing I found the issue on serverless but it probably can be reproduced on on-prem as well On Serverless: - Start a local es instance: `yarn es serverless --kill --clean --license trial --ssl` - Enable infra in the `serverless.oblt.dev.yml` file: - `xpack.infra.enabled: true` - Start a local kibana instance: `yarn serverless-oblt --ssl` and see if the side nav contains the Infrastructure item - Navigate to https://0.0.0.0:5601/ftw/app/hosts and open Asset details flyout or page - Click on the process tab and expand one of the processes - The charts (CPU and Memory) should be visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168156
Summary
This PR fixes process charts error:
I assume that after the merge of the refactoring PR, those files were recreated by another PR or most likely when
mainwas merged to the refactoring PR with them as resolved conflicts. Deleting the files again fixed the issue.Testing
I found the issue on serverless but it probably can be reproduced on on-prem as well
On Serverless:
yarn es serverless --kill --clean --license trial --sslserverless.oblt.dev.ymlfile:xpack.infra.enabled: trueyarn serverless-oblt --ssland see if the side nav contains the Infrastructure item